Comments on: Event.Behavior: DSL for JavaScript http://ajaxian.com/archives/eventbehavior-dsl-for-javascript Cleaning up the web with Ajax Thu, 09 Feb 2012 06:55:33 +0000 hourly 1 http://wordpress.org/?v=3.2 By: Colin http://ajaxian.com/archives/eventbehavior-dsl-for-javascript/comment-page-1#comment-249079 Colin Fri, 06 Apr 2007 09:42:07 +0000 http://ajaxian.com/?p=2289#comment-249079 Interesting idea, but please don't sacrifice code quality for dumbed down readability, that's what comments are for. One of the examples on that page is: with(Event.Behavior){ add_class_name('black').to('paragraph').when('color_select').is('black'); add_class_name('red').to('paragraph').when('color_select').is('red'); add_class_name('green').to('paragraph').when('color_select').is('green'); add_class_name('blue').to('paragraph').when('color_select').is('blue'); add_class_name('bold').to('paragraph').when('weight_select').is('bold'); add_class_name('normal').to('paragraph').when('weight_select').is('normal'); } This should be simply: $('color_select','weight_select').invoke('observe','change',function(event){ $('paragraph').addClassName(Event.element(event).value); }); I could be wrong but I'm guessing each Event.Behavior "statement" is a separate event observer, so not only is this example extremely verbose, but it's also very inefficient and not maintainable. However, some other examples they used were actually pretty cool. Suggestion: for all constructs that can take a function which returns an array of elements, you could make the code much cleaner by allowing you to pass a string which is assumed to be a CSS selector, in which case it would pass that to $$ itself rather than requiring you to pass it a function that just wraps $$. This would also be more readable since you don't have ugly inline functions or functions defined elsewhere. Example: with(Event.Behavior){ set_style(styles).on('#font_picker p').when('#font_picker select').change(); } Interesting idea, but please don’t sacrifice code quality for dumbed down readability, that’s what comments are for. One of the examples on that page is:
with(Event.Behavior){
add_class_name(‘black’).to(‘paragraph’).when(‘color_select’).is(‘black’);
add_class_name(‘red’).to(‘paragraph’).when(‘color_select’).is(‘red’);
add_class_name(‘green’).to(‘paragraph’).when(‘color_select’).is(‘green’);
add_class_name(‘blue’).to(‘paragraph’).when(‘color_select’).is(‘blue’);
add_class_name(‘bold’).to(‘paragraph’).when(‘weight_select’).is(‘bold’);
add_class_name(‘normal’).to(‘paragraph’).when(‘weight_select’).is(‘normal’);
}

This should be simply:
$(‘color_select’,'weight_select’).invoke(‘observe’,'change’,function(event){
$(‘paragraph’).addClassName(Event.element(event).value);
});

I could be wrong but I’m guessing each Event.Behavior “statement” is a separate event observer, so not only is this example extremely verbose, but it’s also very inefficient and not maintainable. However, some other examples they used were actually pretty cool.

Suggestion: for all constructs that can take a function which returns an array of elements, you could make the code much cleaner by allowing you to pass a string which is assumed to be a CSS selector, in which case it would pass that to $$ itself rather than requiring you to pass it a function that just wraps $$. This would also be more readable since you don’t have ugly inline functions or functions defined elsewhere.
Example:
with(Event.Behavior){
set_style(styles).on(‘#font_picker p’).when(‘#font_picker select’).change();
}

]]> By: andy http://ajaxian.com/archives/eventbehavior-dsl-for-javascript/comment-page-1#comment-249063 andy Thu, 05 Apr 2007 21:16:06 +0000 http://ajaxian.com/?p=2289#comment-249063 i thought pseudocode meant code that shows an idea but doesn't actually run i thought pseudocode meant code that shows an idea but doesn’t actually run

]]> By: steve http://ajaxian.com/archives/eventbehavior-dsl-for-javascript/comment-page-1#comment-249061 steve Thu, 05 Apr 2007 21:04:59 +0000 http://ajaxian.com/?p=2289#comment-249061 um..... can anyone say "big deal" and/or why is pseudocode being heralded as an invention?? um….. can anyone say “big deal” and/or why is pseudocode being heralded as an invention??

]]> By: Andres Almiray http://ajaxian.com/archives/eventbehavior-dsl-for-javascript/comment-page-1#comment-249055 Andres Almiray Thu, 05 Apr 2007 19:16:12 +0000 http://ajaxian.com/?p=2289#comment-249055 Very interesting indeed. I bet Adam didn't see this one coming. Congrats to Ryan on putting a good idea to work. Very interesting indeed. I bet Adam didn’t see this one coming. Congrats to Ryan on putting a good idea to work.

]]> By: Nicolas http://ajaxian.com/archives/eventbehavior-dsl-for-javascript/comment-page-1#comment-249043 Nicolas Thu, 05 Apr 2007 14:02:00 +0000 http://ajaxian.com/?p=2289#comment-249043 Wow very insteresting project ... bonus, It will help me to improve my english ;) Wow very insteresting project … bonus, It will help me to improve my english ;)

]]>