Comments on: Simply Buttons

By: ExtAnimal

ExtAnimal — Wed, 25 Nov 2009 12:33:05 +0000

Quite nice. But fixed height, not scalable. What if someone wants paw-sized buttons for a touchscreen app?

By: p51labs

p51labs — Thu, 19 Nov 2009 20:28:49 +0000

@zulugrid: HAHA :) Just goes to show ya that there are people that prefer to knock something before they actually read…

By: zulugrid

zulugrid — Thu, 19 Nov 2009 17:53:11 +0000

@MaratDenenberg: You do realize that the page you linked to also requires JS to be cross-browser, right?

By: sixtyseconds

sixtyseconds — Thu, 19 Nov 2009 05:00:35 +0000

it’s from me :D

By: p51labs

p51labs — Wed, 18 Nov 2009 21:07:06 +0000

My bad guys and my apologies to kangax, I read all the comments at once and clumped kangax with RyanMorr and some others.

@kangax: Thanks for the pointers, I already have a list of todo’s for the JS end and it will only get better from here :)

@sixtyseconds: I love that quote, who is it from? I agree, constructive comments are always the best, that’s how things get better ;)

Kevin

By: sixtyseconds

sixtyseconds — Wed, 18 Nov 2009 20:36:31 +0000

@p51labs – good sportsmanship is completely ignoring all criticism. good coding is accepting informed criticism with grace… :P

By: kangax

kangax — Wed, 18 Nov 2009 20:12:38 +0000

@p51labs Childish, huh :) Didn’t I list few things that were out of place? Is that not a suggestion?

By: p51labs

p51labs — Wed, 18 Nov 2009 19:05:05 +0000

Hi-

Thanks for everyones feedback, that’s what I am always looking for. I would like to address a few things though.

@kangax and the likes: Thank you for being so childish, next time please offer up some suggestions for improvement. This JS is not necessary and is the first version without a framework.

@MaratDenenberg: I did not steal the design, in fact I link to oscar. More over the buttons are generic and are to show off the technique, its not like I stole the youtube buttons as well.

Once again thanks for the feedback guys, this is how we get new generations of code out there that work better than the last.

Kevin

By: WillPeavy

WillPeavy — Wed, 18 Nov 2009 18:18:28 +0000

Those are some nice Web 2.0 buttons. However, I’m currently on Web 3.1., so they are too dated looking for me to use.

By: MaratDenenberg

MaratDenenberg — Wed, 18 Nov 2009 17:39:00 +0000

Well, one good thing came out of this. There is no reason for javascript to be involved in buttons. Fortunately, the nice gentleman who stole the button design posted a link to a page where that design is implemented with just images and CSS: http://www.oscaralexander.com/tutorials/how-to-make-sexy-buttons-with-css.html

By: parsap

parsap — Wed, 18 Nov 2009 17:35:01 +0000

Only on Ajaxian ;). Articles about hardcore JavaScript optimization one day, and then an article about a crappy “button library” the next.

By: Nosredna

Nosredna — Wed, 18 Nov 2009 16:26:50 +0000

They are pretty, though. :-)

By: RyanMorr

RyanMorr — Wed, 18 Nov 2009 16:23:46 +0000

@blepore, my bad I didn’t notice that. Maybe it’s for the best, I almost threw up in my mouth when I saw the code kangax was eluding to.

By: blepore

blepore — Wed, 18 Nov 2009 15:02:09 +0000

@RyanMorr looks like kangax’s link has a trailing ) that shouldn’t be in the link.

By: RyanMorr

RyanMorr — Wed, 18 Nov 2009 14:22:21 +0000

@kangax, uh-oh, I think you scared him away, the link to the JS is dead.

By: posaune

posaune — Wed, 18 Nov 2009 14:01:43 +0000

Has anyone seen any usability studies about what type of cursor to use for buttons/links? By default, buttons and input=submit elements don’t use the ‘pointer’ cursor. Now that we style buttons to look like links (to facilitate POST/PUT/DELETE links, for instance) and links to look like buttons, is there a best practice for which cursor to use?

By: kangax

kangax — Wed, 18 Nov 2009 13:16:04 +0000

Too bad the script itself is rather poor (http://www.p51labs.com/projects/buttons/javascripts/SimplyButtons.js): tests for presence of class the wrong way (using boundaries), uses getAttribute/setAttribute to copy intrinsic event properties (!), wastes memory by creating unnecessary array objects in a loop (which could be created once), uses `attachEvent` after sniffing for `document.all`, etc…